Emote ports #36
Merged
Emote ports #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Debugging is still needed, some parts are not working. This is just to get the grunt work done before getting to the nitty gritty.
Final batch of emote porting.
Running through and fixing bugs.
"ah" is currently giving problems.
Closed
MosleyTheMalO
requested changes
Aug 13, 2024
There was a problem hiding this comment.
Every run_emote override that's used only to select the sound of an emote should be replaced by a get_sound() override similar to the fart emote
Comment on lines
+691
to
+696
|
|
||
| // Set random emote sound | ||
| sound = pick('modular_zzplurt/sound/voice/aauugghh1.ogg', 'modular_zzplurt/sound/voice/aauugghh2.ogg') | ||
|
|
||
| // Return normally | ||
| . = ..() |
There was a problem hiding this comment.
Suggested change
| // Set random emote sound | |
| sound = pick('modular_zzplurt/sound/voice/aauugghh1.ogg', 'modular_zzplurt/sound/voice/aauugghh2.ogg') | |
| // Return normally | |
| . = ..() | |
| // Return normally | |
| . = ..() | |
| /datum/emote/living/snore/snore2/get_sound(mob/living/user) | |
| return pick('modular_zzplurt/sound/voice/aauugghh1.ogg', 'modular_zzplurt/sound/voice/aauugghh2.ogg') |
Switched run_emote to get_sound.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not quite working yet, error is happening. Making a PR for Mosley to have a look at.